Repeating and Single Queries - Webmaster Forum - Web Design, Programming and SEO forums

07-07-2008, 06:03 AM

Jako

Status: Jakowenko.com
Join date: Jun 2005
Location: Michigan
Expertise:
Software:

Posts: 2,199

iTrader: 3 / 100%

Jako is on a distinguished road

Repeating and Single Queries

I was running this query on my website.

PHP Code:


			
<? include('variables.php'); ?>

<? 

$id=$_GET['id'];

$query = "SELECT * FROM players, national WHERE players.national='$id' AND national.national='$id'";

if ($r = mysql_query ($query)) {

while ($row = mysql_fetch_array ($r)) { 



?>

and at the bottom of the page I had something like

PHP Code:


			
<? } } die() ?>

This loop was pulling everything from the database that met that query. So everything was being repeated though I only wanted a section of the page repeat, while the rest only gets posted a single time.

How would I go about doing this?

01-12-2009, 07:24 PM

trench

Status: I'm new around here
Join date: Nov 2008
Location:
Expertise:
Software:

Posts: 13

iTrader: 0 / 0%

trench is on a distinguished road

Read up on INNER/LEFT/RIGHT JOIN mysql querys.

01-19-2009, 04:59 PM

paitken

Status: I'm new around here
Join date: Nov 2008
Location: Tampa, FL, USA
Expertise:
Software:

Posts: 14

iTrader: 0 / 0%

paitken is on a distinguished road

It would be a little better if you would have named your columns a little better.
I would name the 'national' column inside of 'national', 'national_id' or 'id', and make it auto increment.

It's a bit difficult to understand what you're doing. The code you have would of course get all the results from the query. If you just wanted ONE, you would do LIMIT 1 at the end of the query.

trench: A join in this case would be overkill. It would be just as fast if he had the columns properly indexed. It would be useful if he were trying to do multiple joins.

02-20-2009, 02:57 PM

ditch182

Status: Junior Member
Join date: Jul 2008
Location: NC
Expertise:
Software:

Posts: 70

iTrader: 0 / 0%

ditch182 is on a distinguished road

paitken is right, here. What you've got is an implicit join anyway. You could either use LIMIT to return only the first result, or think about using foreach to iterate through your array of results.