|
 |
|
|
|
| Thread title: Terrible CSS! |
 |
|
|
| |
|
Thread tools
Search this thread
Display Modes
|
|
|
03-12-2007, 04:30 AM
|
#1
|
Status: Pastafarian
Join date: May 2006
Location: Duct Taped to your Ceiling
Expertise:
Software:
Posts: 3,440
|
 Terrible CSS!
Code:
center_details_subskin {
background-image: url(../images/brown_corner.gif);
background-repeat: no-repeat;
height: 55px;
padding-left: 218px;
width: 550px;
}
#container_subskin {
background: #ffffff url(../images/left_bg.gif);
background-repeat: repeat-y;
margin-top: -2px;
overflow: hidden;
padding-left: 54px; /* LC width */
padding-right: 40px; /* RC width */
position: relative;
}
#container_subskin .column {
float: left;
margin-bottom: -10000px; /* X */
padding-bottom: 10010px; /* X + padding-bottom */
position: relative;
top: 2px;
}
#text_offset
{
padding-bottom: 50px;
}
#left_subskin {
background: url(../images/left_border.gif) no-repeat;
background-repeat: repeat-y;
background-color: #FFF;
margin-left: -100%;
left: 40px; /* LC width */
width: 54px; /* LC width */
}
#container_subskin > #left_subskin {
left: -54px; /* -(LC fullwidth + CC padding) */
}
.sub_text_offset_clear {
clear: both;
padding: 18px 0 8px 0;
}
Have you ever seen such crap? Negative margin this, absolute position that. Terrible.
Grrrr. I hate fixing other peoples stupidity. It's a friggin simple layout too.
|
|
|
|
03-12-2007, 04:33 AM
|
#2
|
Status: Waving
Join date: Aug 2005
Location:
Expertise:
Software:
Posts: 2,694
|
Originally Posted by Blue Ire 
Code:
center_details_subskin {
background-image: url(../images/brown_corner.gif);
background-repeat: no-repeat;
height: 55px;
padding-left: 218px;
width: 550px;
}
#container_subskin {
background: #ffffff url(../images/left_bg.gif);
background-repeat: repeat-y;
margin-top: -2px;
overflow: hidden;
padding-left: 54px; /* LC width */
padding-right: 40px; /* RC width */
position: relative;
}
#container_subskin .column {
float: left;
margin-bottom: -10000px; /* X */
padding-bottom: 10010px; /* X + padding-bottom */
position: relative;
top: 2px;
}
#text_offset
{
padding-bottom: 50px;
}
#left_subskin {
background: url(../images/left_border.gif) no-repeat;
background-repeat: repeat-y;
background-color: #FFF;
margin-left: -100%;
left: 40px; /* LC width */
width: 54px; /* LC width */
}
#container_subskin > #left_subskin {
left: -54px; /* -(LC fullwidth + CC padding) */
}
.sub_text_offset_clear {
clear: both;
padding: 18px 0 8px 0;
}
Have you ever seen such crap? Negative margin this, absolute position that. Terrible.
Grrrr. I hate fixing other peoples stupidity. It's a friggin simple layout too.
|
#container_subskin .column, is just add 10 pixels of padding on the bottom all together. HAHA
|
|
|
|
03-12-2007, 05:23 AM
|
#3
|
Status: On Vacation
Join date: Aug 2006
Location:
Expertise:
Software:
Posts: 873
|
I am sure both of you wrote perfect code the first day you learned.
|
|
|
|
03-12-2007, 08:31 AM
|
#4
|
Status: I love this place
Join date: Jun 2005
Location: UK
Expertise:
Software:
Posts: 562
|
I hate working with other people's code. I'd rather just code it from scratch, lol.
|
|
|
|
03-12-2007, 10:25 AM
|
#5
|
Status: I love this place
Join date: Jan 2005
Location: London
Expertise:
Software:
Posts: 608
|
Originally Posted by damien11
I am sure both of you wrote perfect code the first day you learned.
|
Thats what I was just think. They both came straight out of the womb riding a bike (with no hands).
|
|
|
|
03-12-2007, 02:22 PM
|
#6
|
Status: Member
Join date: Oct 2005
Location: Calgary, Alberta, Canada
Expertise:
Software:
Posts: 278
|
nerd elitest. wow. guess they gots mad skillz at minesweeper too.
|
|
|
|
03-12-2007, 03:29 PM
|
#7
|
Status: Request a custom title
Join date: Dec 2005
Location: Arizona
Expertise:
Software:
Posts: 5,200
|
Yeah, that's pretty bad. Adding on to what daz said:
I just bought a site from Garrett, and the coding is great, (except one small error which is an easy fix), but I can't stand with working with other peoples code so I'm just going to be recoding it from scratch, so I don't go crazy.
|
|
|
|
03-12-2007, 04:06 PM
|
#8
|
Status: Community Archaeologist
Join date: Jul 2004
Location: Scotland
Expertise: Software Development
Software: vim, PHP
Posts: 3,820
|
It's certainly not the most beautiful CSS I've ever seen, but if you're going to highlight bad code then at least highlight what is bad and how it could be improved (in your own experience). Then we can all discuss it, as experts in the field.
Maybe I'm just blind, but I see no absolute positioning whatsoever and there's nothing wrong with negative margins when used, as is always the case, appropriately. It just seems like the code of an inexperienced (read: they'll improve with time) person is all. Nothing major. At least you're getting paid to fix the god awful mess they made, right? 
|
|
|
|
03-12-2007, 04:51 PM
|
#9
|
Status: Pastafarian
Join date: May 2006
Location: Duct Taped to your Ceiling
Expertise:
Software:
Posts: 3,440
|
Originally Posted by damien11
I am sure both of you wrote perfect code the first day you learned.
|
I don't sell services that I can't provide competently If you are learning, you have no business offering "Professional Services".
|
|
|
|
03-12-2007, 05:53 PM
|
#10
|
Status: design rockstar
Join date: Jan 2005
Location: guelph, ontario
Expertise:
Software:
Posts: 2,246
|
exactly.
there's almost never a need for negative margins. i've used negative margins, and positioning for practical reasons, but they're very few and far between.
margin-left: -100%;
and
margin-bottom: -10000px; /* X */
padding-bottom: 10010px; /* X + padding-bottom */
are just ridiculous.
|
|
|
|
|
|
|
|
|
|
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
|
|
|
|
|
Linear Mode
Forum Contains New Posts 
Forum Contains No New Posts 
Forum is Closed