line height

what ever noob coded the skin clearly had no idea how to handle line-height...

http://www.talkfreelance.com/showthread.php?t=45995

someone please fix

I think this could go in Skin Bug thread.

Be slightly nice.

Originally Posted by Blue Ire what ever noob coded the skin clearly had no idea how to handle line-height...

I take it thats a joke? If not it seems a bit ironic how when you did some coding for me you missed multiple simple things

I think Blue was making a valid point regarding whoever handled the CSS for this skin. It doesn't matter whether he has made "multiple simple" errors before in his own work, the fact still stands that whoever coded this skin forgot, overlooked or plain didn't know how to handle the line-height.

Simple fix, lets see it done.

Man, that first line is very dramatic and somewhat rude. But I won't go there...

You now, it looks as if he's just set a set line height for the posts which caused bigger fonts don't auto ajust. I haven't taken a look at the code myself yet but that's what I'm guessing.

But damn, a single mistake or even a genuine overlook does not mean you CLEARLY don't know anything about it and you're a NOOB. People make mistakes and not to mention the fact that the skin was rushed to a finish anyway.

EDIT: Aye, I thought it was a set height for posts. The problem is simply "line-height: 16px;" in the .message class. Delete and problem fixed. Kinda makes the first post seem even more rediculous as to how simple of a mistake it realy was Anybody could have left that there by accident, nomatter how professional you are. Probably because we are human

Peace, Lance

Valid point yes, rude yes - i wouldnt expect anything less.

Anyway, lets see this get done Simple to do!

Originally Posted by Lance... Kinda makes the first post seem even more rediculous as to how simple of a mistake it realy was Anybody could have left that there by accident, nomatter how professional you are. Probably because we are human

A competent CSS coder would never use pixel units for line-height, ever. It's not a mistake that was overlooked (because we're all human), it was someone not knowing what they're doing (because we're not all perfect). But this is really a teeny, tiny issue and not worth the amount of time being spent discussing it.

I'm pretty sure Aros knows about line height, he probably just forgot to change it from the standard html version (which I'm guessing will have had a fixed line height for appearance purposes as it only used one size font).

Anyway, it's not a huge deal - for the time being (until it's fixed) if it discourages the use of huge text in posts then it's all good

Heh, you're right. I just contributed to the pointless bickering that happens here. Oops Oh well, easy to fix so no worries

Peace, Lance