View Single Post
01-11-2007, 03:57 PM
#18
fernand is offline fernand
Status: I'm new around here
Join date: Nov 2006
Location:
Expertise:
Software:
 
Posts: 18
iTrader: 0 / 0%
 

fernand is on a distinguished road

  Old

Originally Posted by Wildhoney
I can code fluently in PHP5. True OOP with Interface and Abstract classes. Basically the lot. A little sample here -> http://www.adam.tiaghosting.com/sample/
well, good sample but i have some comments for your code:
1. it's too many type castings for private properties. if you know how ZE handles object properties, you'll find the reason why. don't add the overhead if it's not necessary.
2. considering logic separation, it's not good practice to put DB properties in class constant. when the class is put together with another package, configuration should be done directly to the class file and not config file, which will make the application less versatile and user (read: developer) friendly.

so far, my most favorite php programmer is rasmus (lerdorf). if you don't know him (which i am sure most of you do), please take a look how rasmus uses php as a toy here: http://talks.php.net/show/oscon06